Fix typeassert error in read_refs #170
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DilumAluthge
changed the title
|
Hmmmm so now it passes on some platform/version combos and fails on others. Are these fails related to this patch, or due to other causes? |
tkelman
reviewed
Jul 19, 2017
src/JLD.jl
Outdated
| end | ||
| return out | ||
| else | ||
| throw(e) |
There was a problem hiding this comment.
rethrow would preserve the backtrace
There was a problem hiding this comment.
Changed throw(e) to rethrow(e)!
An assignment like this should cause it to convert one type to the other, and not throw a Type Error |
|
I'm closing this PR for now; I'll reopen if the issue reappears! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes a typeassert error that arises in the read_refs function in src/JLD.jl:482. The error arises when, for example,
eltype(out)isArray{Array,1}buttypeof(read_ref(f, refs[i]))isArray{Array{Float32,1},1}.Array{Float32,1}is a subtype ofArray, butArray{Array{Float32,1},1}is not a subtype ofArray{Array,1}because in Julia type parameters are invariant.Thus, if you try to assign a value of type
Array{Array{Float32,1},1}toout[i], butout[i]is expecting a value of typeArray{Array,1}, then a TypeAssert is thrown.The simple workaround is to change the type of
outfromArray{T}toArray{Any}.Fixes #154 in this repo as well as pluskid/Mocha.jl#219 and pluskid/Mocha.jl#229. (All are the same issue.)